SteNicholas commented on code in PR #2482:
URL: https://github.com/apache/celeborn/pull/2482#discussion_r1591210033
##########
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -420,6 +424,20 @@ private int executorCores(SparkConf conf) {
}
}
+ private void checkUserClassPathFirst() {
+ if ((Boolean) conf.get(package$.MODULE$.EXECUTOR_USER_CLASS_PATH_FIRST()))
{
Review Comment:
@cfmcgrady, I have updated the description of the case that highly recommend
to set `spark.executor.userClassPathFirst` to false. Meanwhile, could you take
a look at the description of this pull request, which has already mentioned the
difference of the classloader with the way `--jars/spark.jars`? When setting
`spark.executor.userClassPathFirst` to true and using `--jars/spark.jars` to
specify the user jar, the classloader of `handle` is
`ChildFirstURLClassLoader`, but the classloader of `CelebornShuffleHandle` is
`AppClassLoader`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
