SteNicholas commented on code in PR #2555:
URL: https://github.com/apache/celeborn/pull/2555#discussion_r1677447020
##########
client/src/main/java/org/apache/celeborn/client/read/LocalPartitionReader.java:
##########
@@ -51,7 +51,7 @@
public class LocalPartitionReader implements PartitionReader {
private static final Logger logger =
LoggerFactory.getLogger(LocalPartitionReader.class);
- private static volatile ThreadPoolExecutor readLocalShufflePool;
+ private volatile ThreadPoolExecutor readLocalShufflePool;
Review Comment:
@mridulm, this static variable does not satisfy
[StaticAssignmentInConstructor](https://errorprone.info/bugpattern/StaticAssignmentInConstructor).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
