mridulm commented on code in PR #2596:
URL: https://github.com/apache/celeborn/pull/2596#discussion_r1663558406
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/network/FlinkTransportClientFactory.java:
##########
@@ -63,7 +66,13 @@ public TransportClient createClientWithRetry(String
remoteHost, int remotePort)
remotePort,
e);
if (retryCount == 0) {
- throw e;
+ if (e instanceof InterruptedException) {
+ throw (InterruptedException) e;
+ } else if (e instanceof IOException) {
+ throw (IOException) e;
+ } else {
+ Utils.rethrowAsRuntimeException(e);
+ }
Review Comment:
Interesting java 7 feature - I was only aware of the `|` in `catch` - not
that same thing applied to more precise rethrows via `if` as well !
Will change to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
