mridulm commented on code in PR #2596:
URL: https://github.com/apache/celeborn/pull/2596#discussion_r1663562872
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/readclient/FlinkShuffleClientImpl.java:
##########
@@ -133,15 +136,33 @@ public FlinkShuffleClientImpl(
String module = TransportModuleConstants.DATA_MODULE;
TransportConf dataTransportConf =
Utils.fromCelebornConf(conf, module, conf.getInt("celeborn." + module
+ ".io.threads", 8));
- TransportContext context =
+ this.context =
new TransportContext(
dataTransportConf, readClientHandler,
conf.clientCloseIdleConnections());
- this.flinkTransportClientFactory =
- new FlinkTransportClientFactory(context,
conf.clientFetchMaxRetriesForEachReplica());
this.setupLifecycleManagerRef(driverHost, port);
this.driverTimestamp = driverTimestamp;
}
+ private void initializeFlinkTransportClientFactory() {
Review Comment:
I went back and forth on this a bit - I had started with
`flinkTransportClientFactory` as an `AtomicReference` for threadsafety and
ensure visibility across threads ...
But looking at `ShuffleClientImpl`, this looked like unnecessary
complication.
`initializeTransportClientFactoryIfRequired` vs
`initializeFlinkTransportClientFactory` is an artifact of this ... which looks
like I forgot to clean up.
The only difference is the log message ...
Thanks for catching !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
