mridulm commented on code in PR #2596:
URL: https://github.com/apache/celeborn/pull/2596#discussion_r1663560117
##########
client-flink/common/src/main/java/org/apache/celeborn/plugin/flink/readclient/FlinkShuffleClientImpl.java:
##########
@@ -565,6 +587,15 @@ public void setDataClientFactory(TransportClientFactory
dataClientFactory) {
@Override
@VisibleForTesting
public TransportClientFactory getDataClientFactory() {
+ initializeTransportClientFactoryIfRequired();
return flinkTransportClientFactory;
}
+
+ private void initializeTransportClientFactoryIfRequired() {
+ if (null == flinkTransportClientFactory) {
+ logger.info(
+ "FlinkTransportClientFactory has not been initialized, " +
"initializing with default");
Review Comment:
I had it in two lines - but looks like spotless combined two lines into one
- but left the concat :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
