pan3793 commented on code in PR #2604:
URL: https://github.com/apache/celeborn/pull/2604#discussion_r1666533035
##########
common/src/main/scala/org/apache/celeborn/common/authentication/TokenAuthenticationProvider.scala:
##########
@@ -28,10 +28,15 @@ trait TokenAuthenticationProvider {
* When the token is to be disallowed, throw an appropriate
[[SecurityException]].
*
* @param token The token received over the connection request.
+ * @param props The properties associated with the token
* @return The identifier associated with the token
*
* @throws SecurityException When the token is found to be invalid by the
implementation
*/
@throws[SecurityException]
- def authenticate(token: String): Principal
+ def authenticate(token: String, props: Map[String, String]): Principal
Review Comment:
To avoid breaking API again, maybe we can introduce a `Credential` interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
