turboFei commented on code in PR #2604:
URL: https://github.com/apache/celeborn/pull/2604#discussion_r1666979616
##########
common/src/main/scala/org/apache/celeborn/common/authentication/TokenAuthenticationProvider.scala:
##########
@@ -23,15 +23,19 @@ trait TokenAuthenticationProvider {
/**
* The authenticate method is called by the celeborn authentication layer
- * to authenticate token for their requests.
- * If the token is to be granted, return nothing/throw nothing.
- * When the token is to be disallowed, throw an appropriate
[[SecurityException]].
+ * to authenticate credential for their requests.
+ * If the credential is to be granted, return nothing/throw nothing.
+ * When the credential is to be disallowed, throw an appropriate
[[SecurityException]].
*
- * @param token The token received over the connection request.
+ * @param credential The credential received over the connection request
* @return The identifier associated with the token
*
- * @throws SecurityException When the token is found to be invalid by the
implementation
+ * @throws SecurityException When the credential is found to be invalid by
the implementation
*/
@throws[SecurityException]
- def authenticate(token: String): Principal
+ def authenticate(credential: TokenCredential): Principal
+}
+
+object TokenAuthenticationProvider {
+ val CLIENT_IP_PROPERTY = "CLIENT_IP"
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
