pan3793 commented on code in PR #2604:
URL: https://github.com/apache/celeborn/pull/2604#discussion_r1666987775
##########
service/src/test/scala/org/apache/celeborn/server/common/http/authentication/UserDefinePasswordAuthenticationProviderImpl.scala:
##########
@@ -20,16 +20,18 @@ package
org.apache.celeborn.server.common.http.authentication
import java.security.Principal
import javax.security.sasl.AuthenticationException
-import org.apache.celeborn.common.authentication.{BasicPrincipal,
PasswdAuthenticationProvider}
+import org.apache.celeborn.common.authentication.{BasicPrincipal, Credential,
PasswdAuthenticationProvider, PasswordCredential}
import org.apache.celeborn.common.internal.Logging
import
org.apache.celeborn.server.common.http.authentication.UserDefinePasswordAuthenticationProviderImpl.VALID_PASSWORD
class UserDefinePasswordAuthenticationProviderImpl
extends PasswdAuthenticationProvider with Logging {
- override def authenticate(user: String, password: String): Principal = {
- if (password == VALID_PASSWORD) {
- logInfo(s"Success log in of user: $user")
- new BasicPrincipal(user)
+ override def authenticate(credential: PasswordCredential): Principal = {
+ val clientIp =
+ credential.extraInfo.getOrElse(Credential.CLIENT_IP_PROPERTY, null)
Review Comment:
```suggestion
credential.extraInfo.getOrElse(Credential.CLIENT_IP_KEY, null)
```
##########
common/src/main/scala/org/apache/celeborn/common/authentication/Credential.scala:
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.common.authentication
+
+trait PasswordCredential {
+ def username: String
+ def password: String
+ def extraInfo: Map[String, String] = Map.empty
+}
+
+case class DefaultPasswordCredential(
+ username: String,
+ password: String,
+ override val extraInfo: Map[String, String] = Map.empty) extends
PasswordCredential
+
+trait TokenCredential {
+ def token: String
+ def extraInfo: Map[String, String] = Map.empty
+}
+
+case class DefaultTokenCredential(
+ token: String,
+ override val extraInfo: Map[String, String] = Map.empty) extends
TokenCredential
+
+object Credential {
+ val CLIENT_IP_PROPERTY = "clientIp"
Review Comment:
```suggestion
val CLIENT_IP_KEY = "clientIp"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
