SteNicholas commented on code in PR #2555:
URL: https://github.com/apache/celeborn/pull/2555#discussion_r1677457368
##########
common/src/test/java/org/apache/celeborn/common/network/ssl/ReloadingX509TrustManagerSuiteJ.java:
##########
@@ -101,15 +101,7 @@ public void testLoadMissingTrustStore() throws Exception {
assertThrows(
IOException.class,
- () -> {
- ReloadingX509TrustManager tm =
- new ReloadingX509TrustManager(KeyStore.getDefaultType(),
trustStore, "password", 10);
- try {
- tm.init();
- } finally {
- tm.destroy();
- }
- });
+ () -> new ReloadingX509TrustManager(KeyStore.getDefaultType(),
trustStore, "password", 10));
Review Comment:
@mridulm, `init` does not throw `IOException`, therefore this does not need
to call `init`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
