s0nskar commented on code in PR #2629:
URL: https://github.com/apache/celeborn/pull/2629#discussion_r1691339291
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2094,6 +2084,16 @@ object CelebornConf extends Logging {
"Allowed pattern is: `<host1>:<port1>[,<host2>:<port2>]*`")
.createWithDefaultString(s"<localhost>:9097")
+ val MASTER_ENDPOINTS_RESOLVER: ConfigEntry[String] =
+ buildConf("celeborn.master.endpoints.resolver")
+ .categories("client", "worker")
+ .doc("Resolver class that can be used for dynamically discovering and
updating the master endpoints. " +
Review Comment:
I've added a new check to verify if resolver class is loadable. Which throws
"Resolver class was not found in the classpath. Please check the class name and
ensure that it is present in classpath" error if class is not found.
> give the default implementation for this situation?
IMO this can lead to unexpected behaviour during runtime, so its better we
fast fail incase resolve class is not found.
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2094,6 +2084,16 @@ object CelebornConf extends Logging {
"Allowed pattern is: `<host1>:<port1>[,<host2>:<port2>]*`")
.createWithDefaultString(s"<localhost>:9097")
+ val MASTER_ENDPOINTS_RESOLVER: ConfigEntry[String] =
+ buildConf("celeborn.master.endpoints.resolver")
+ .categories("client", "worker")
+ .doc("Resolver class that can be used for dynamically discovering and
updating the master endpoints. " +
Review Comment:
I've added a new check to verify if resolver class is loadable. Which throws
"Resolver class was not found in the classpath. Please check the class name and
ensure that it is present in classpath" error if class is not found.
> give the default implementation for this situation?
IMO this can lead to unexpected behaviour during runtime, so its better we
fast fail incase resolver class is not found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
