bowenliang123 commented on code in PR #2701:
URL: https://github.com/apache/celeborn/pull/2701#discussion_r1739867942
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1573,12 +1577,32 @@ class LifecycleManager(val appUniqueId: String, val
conf: CelebornConf) extends
latestPartitionLocation.remove(shuffleId)
commitManager.removeExpiredShuffle(shuffleId)
changePartitionManager.removeExpiredShuffle(shuffleId)
- val unregisterShuffleResponse = requestMasterUnregisterShuffle(
- UnregisterShuffle(appUniqueId, shuffleId,
MasterClient.genRequestId()))
- // if unregister shuffle not success, wait next turn
- if (StatusCode.SUCCESS ==
Utils.toStatusCode(unregisterShuffleResponse.getStatus)) {
+ if (!batchRemoveExpiredShuffles) {
+ val unregisterShuffleResponse = requestMasterUnregisterShuffle(
+ UnregisterShuffle(appUniqueId, shuffleId,
MasterClient.genRequestId()))
+ // if unregister shuffle not success, wait next turn
+ if (StatusCode.SUCCESS ==
Utils.toStatusCode(unregisterShuffleResponse.getStatus)) {
+ unregisterShuffleTime.remove(shuffleId)
+ }
+ } else {
+ batchRemoveShuffleIds.add(shuffleId)
+ }
+ }
+ }
+ if (!batchRemoveShuffleIds.isEmpty) {
Review Comment:
OK. But to be honest, the current implementation of the whole function is
far from the best.
Or let me raise another followup pr to improve it.
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1573,12 +1577,32 @@ class LifecycleManager(val appUniqueId: String, val
conf: CelebornConf) extends
latestPartitionLocation.remove(shuffleId)
commitManager.removeExpiredShuffle(shuffleId)
changePartitionManager.removeExpiredShuffle(shuffleId)
- val unregisterShuffleResponse = requestMasterUnregisterShuffle(
- UnregisterShuffle(appUniqueId, shuffleId,
MasterClient.genRequestId()))
- // if unregister shuffle not success, wait next turn
- if (StatusCode.SUCCESS ==
Utils.toStatusCode(unregisterShuffleResponse.getStatus)) {
+ if (!batchRemoveExpiredShuffles) {
+ val unregisterShuffleResponse = requestMasterUnregisterShuffle(
+ UnregisterShuffle(appUniqueId, shuffleId,
MasterClient.genRequestId()))
+ // if unregister shuffle not success, wait next turn
+ if (StatusCode.SUCCESS ==
Utils.toStatusCode(unregisterShuffleResponse.getStatus)) {
+ unregisterShuffleTime.remove(shuffleId)
+ }
+ } else {
+ batchRemoveShuffleIds.add(shuffleId)
+ }
+ }
+ }
+ if (!batchRemoveShuffleIds.isEmpty) {
Review Comment:
OK. But to be honest, the current implementation of the whole function is
far from the best.
Or let me raise another followup PR to improve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
