zaynt4606 commented on code in PR #2701:
URL: https://github.com/apache/celeborn/pull/2701#discussion_r1766684808
##########
common/src/main/proto/TransportMessages.proto:
##########
@@ -402,10 +404,26 @@ message PbUnregisterShuffle {
string requestId = 3;
}
+message PbBatchUnregisterShuffles {
+ string appId = 1;
+ string requestId = 2;
+ repeated int32 shuffleIds = 3;
+}
+
message PbUnregisterShuffleResponse {
int32 status = 1;
}
+message PbBatchUnregisterShuffleResponses {
+ int32 status = 1;
+ repeated PbUnregisterShuffleResponsesInfo unregisterShuffleResponsesInfo = 2;
+}
+
+message PbUnregisterShuffleResponsesInfo {
Review Comment:
Thanks!
PbBatchUnregisterShuffleResponses can be simplified since there is no logic
to process the failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
