zaynt4606 commented on code in PR #2701:
URL: https://github.com/apache/celeborn/pull/2701#discussion_r1739646293
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1655,6 +1693,25 @@ class LifecycleManager(val appUniqueId: String, val
conf: CelebornConf) extends
}
}
+ private def batchRequestMasterUnregisterShuffles(message:
PbBatchUnregisterShuffles)
+ : PbBatchUnregisterShuffleResponses = {
+ try {
+ logInfo(s"AskSync UnregisterShuffle for ${message.getShuffleIdsList}")
+ masterClient.askSync[PbBatchUnregisterShuffleResponses](
+ message,
+ classOf[PbBatchUnregisterShuffleResponses])
+ } catch {
+ case e: Exception =>
+ logError(s"AskSync UnregisterShuffle for ${message.getShuffleIdsList}
failed.", e)
+ val map = JavaUtils.newConcurrentHashMap[Integer, StatusCode]()
+ val shuffleIds = message.getShuffleIdsList
Review Comment:
In this case, all subsets are anomalous and there is no need for repeated
checks.The part related to filling the map has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
