RexXiong commented on code in PR #2373:
URL: https://github.com/apache/celeborn/pull/2373#discussion_r1893610098
##########
client/src/main/scala/org/apache/celeborn/client/commit/ReducePartitionCommitHandler.scala:
##########
@@ -82,6 +85,22 @@ class ReducePartitionCommitHandler(
.maximumSize(rpcCacheSize)
.build().asInstanceOf[Cache[Int, ByteBuffer]]
+ private val newShuffleId2PushFailedBatchMapFunc
+ : function.Function[Int, util.HashMap[String,
util.Set[PushFailedBatch]]] =
+ new util.function.Function[Int, util.HashMap[String,
util.Set[PushFailedBatch]]]() {
+ override def apply(s: Int): util.HashMap[String,
util.Set[PushFailedBatch]] = {
+ new util.HashMap[String, util.Set[PushFailedBatch]]()
+ }
+ }
+
+ private val uniqueId2PushFailedBatchMapFunc
+ : function.Function[String, util.Set[PushFailedBatch]] =
+ new util.function.Function[String, util.Set[PushFailedBatch]]() {
+ override def apply(s: String): util.Set[PushFailedBatch] = {
+ Sets.newHashSet[PushFailedBatch]()
Review Comment:
Should be concurrentHashSet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
