mridulm commented on PR #2373: URL: https://github.com/apache/celeborn/pull/2373#issuecomment-2557599436
Thanks for continuing to work on this @wangshengjie123, really appreciate it ! I will try to go over the PR during the holidays. On general comment though ... It has been a while, so I am not very clean on some of the details about this PR. Having said that, I would suggest to minimize changes to Spark directly in order to add support for this PR - if we can find ways to do so. Some of the changes proposed in the diffs, at first read, look a bit disruptive - and are subject to arbitrary failures as spark evolves: even if technically we could justify their correctness, they are subject to being arbitrarily impacted as spark evolves. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
