wangshengjie123 commented on code in PR #2373:
URL: https://github.com/apache/celeborn/pull/2373#discussion_r1895171264
##########
client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java:
##########
@@ -65,26 +69,54 @@ public static CelebornInputStream create(
ExceptionMaker exceptionMaker,
MetricsCallback metricsCallback)
throws IOException {
- if (locations == null || locations.size() == 0) {
+ if (locations == null || locations.isEmpty()) {
return emptyInputStream;
} else {
- return new CelebornInputStreamImpl(
- conf,
- clientFactory,
- shuffleKey,
- locations,
- streamHandlers,
- attempts,
- attemptNumber,
- startMapIndex,
- endMapIndex,
- fetchExcludedWorkers,
- shuffleClient,
- appShuffleId,
- shuffleId,
- partitionId,
- exceptionMaker,
- metricsCallback);
+ // if startMapIndex > endMapIndex, means partition is skew partition.
+ // locations will split to sub-partitions with startMapIndex size.
+ boolean splitSkewPartitionWithoutMapRange =
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
