SteNicholas commented on code in PR #3099:
URL: https://github.com/apache/celeborn/pull/3099#discussion_r1962909551
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/MemoryManager.java:
##########
@@ -338,6 +340,8 @@ public void switchServingState() {
case PUSH_PAUSED:
if (canResumeByPinnedMemory()) {
resumeByPinnedMemory(servingState);
+ } else if (keepResumeByPinnedMemory()) {
+ // do nothing, keep resume for a while
Review Comment:
Could the resume logic merge into one branch? Like:
```
if (pinnedMemoryCheckEnabled) {
if (keepResumeByPinnedMemory(lastState)) {
// do nothing, keep resume for a while
} else {
resumeByPinnedMemory(servingState);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
