RexXiong commented on code in PR #3099:
URL: https://github.com/apache/celeborn/pull/3099#discussion_r1967344506
##########
worker/src/main/java/org/apache/celeborn/service/deploy/worker/memory/MemoryManager.java:
##########
@@ -336,16 +337,14 @@ public void switchServingState() {
}
switch (servingState) {
case PUSH_PAUSED:
- if (canResumeByPinnedMemory()) {
- resumeByPinnedMemory(servingState);
- } else {
+ if (!tryResumeByPinnedMemory(servingState, lastState)) {
pausePushDataCounter.increment();
if (lastState == ServingState.PUSH_AND_REPLICATE_PAUSED) {
- logger.info("Trigger action: RESUME REPLICATE");
resumeReplicate();
} else {
logger.info("Trigger action: PAUSE PUSH");
pausePushDataStartTime = System.currentTimeMillis();
+ resumingByPinnedMemory = false;
Review Comment:
resumingByPinnedMemory need also change to false when servingState changes
to NONE_PAUSED state
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
