FMX commented on PR #3099: URL: https://github.com/apache/celeborn/pull/3099#issuecomment-2680813236
@TheodoreLx There is an issue with this PR. The trimCounter should be moved into the block of the `if(!tryResumeByPinnedMemory(servingState, lastState))`. The current implementation will cause the metric of PAUSE_PUSH_DATA_TIME and PAUSE_PUSH_DATA_AND_REPLICATE_TIME to be larger than the time spent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
