buska88 commented on PR #3090: URL: https://github.com/apache/celeborn/pull/3090#issuecomment-2697014340
> > > @buska88 It would be better to check the validity of a shuffle Id after you get it instead of using a shuffle ID that marked as invalid. > > > You can add the check here > > > https://github.com/apache/celeborn/blob/6a836f9523b7eb03d3eff4bf1c23349bf8270064/client/src/main/java/org/apache/celeborn/client/ShuffleClientImpl.java#L612-L630 > > > > > > Sorry, I don't understand the purpose of checking shuffle id here. If the shuffle id is invalid, what should we do next? > > Maybe we can also throw FetchFailureException and wait task retry OKay.I choose to throw FetchFailException in CelebornShuffleReader(shuffleclientImpl doesn't have spark dependency).And you can have a look at it when you have free time cc @FMX @RexXiong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
