RexXiong commented on code in PR #3090:
URL: https://github.com/apache/celeborn/pull/3090#discussion_r2076676843
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java:
##########
@@ -154,7 +154,7 @@ public static String getAppShuffleIdentifier(int
appShuffleId, TaskContext conte
return appShuffleId + "-" + context.stageId() + "-" +
context.stageAttemptNumber();
}
- public static int celebornShuffleId(
+ public static Tuple2<Integer, Boolean> celebornShuffleId(
Review Comment:
nit: Should we consider throwing a CelebornRuntimeException when an
unavailable celebornShuffleId is encountered? This can allows to catch the
exception within the CelebornShuffleReader while maintaining the existing
method signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
