cxzl25 commented on code in PR #3090:
URL: https://github.com/apache/celeborn/pull/3090#discussion_r2043596515
##########
client-spark/spark-2/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala:
##########
@@ -64,7 +64,23 @@ class CelebornShuffleReader[K, C](
val serializerInstance = dep.serializer.newInstance()
- val shuffleId = SparkUtils.celebornShuffleId(shuffleClient, handle,
context, false)
+ val (shuffleId, success) = SparkUtils.celebornShuffleId(shuffleClient,
handle, context, false)
+ if (!success) {
+ val ce = new UnsupportedOperationException(
+ s"unexpected! there is no finished map stage associated with
appShuffleId ${handle.shuffleId}")
+ if (handle.throwsFetchFailure) {
+ throw new FetchFailedException(
Review Comment:
```
client-spark/spark-2/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala:72:
overloaded method constructor FetchFailedException with alternatives:
```
https://github.com/apache/celeborn/actions/runs/14331163433/job/40489322319?pr=3090#step:4:1295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
