RexXiong commented on code in PR #3214:
URL: https://github.com/apache/celeborn/pull/3214#discussion_r2048473892
##########
common/src/main/scala/org/apache/celeborn/common/identity/IdentityProvider.scala:
##########
@@ -23,6 +23,7 @@ import org.apache.celeborn.common.util.Utils
abstract class IdentityProvider {
Review Comment:
How about pass `conf` to constructor ,eg: `abstract class
IdentityProvider(conf: CelebornConf)`.
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -97,7 +97,7 @@ class LifecycleManager(val appUniqueId: String, val conf:
CelebornConf) extends
// shuffle id -> (partitionId -> newest PartitionLocation)
val latestPartitionLocation =
JavaUtils.newConcurrentHashMap[Int, ConcurrentHashMap[Int,
PartitionLocation]]()
- private val userIdentifier: UserIdentifier =
IdentityProvider.instantiate(conf).provide()
+ private val userIdentifier: UserIdentifier =
IdentityProvider.instantiate(conf).provide(conf)
Review Comment:
It's a bit strange because we need to pass the conf twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
