AmandeepSingh285 commented on code in PR #3214:
URL: https://github.com/apache/celeborn/pull/3214#discussion_r2048947675
##########
common/src/main/scala/org/apache/celeborn/common/identity/HadoopBasedIdentityProvider.scala:
##########
@@ -19,10 +19,20 @@ package org.apache.celeborn.common.identity
import org.apache.hadoop.security.UserGroupInformation
+import org.apache.celeborn.common.CelebornConf
+
class HadoopBasedIdentityProvider extends IdentityProvider {
- override def provide(): UserIdentifier = {
+ def provideUserIdentifier(): UserIdentifier = {
UserIdentifier(
IdentityProvider.DEFAULT_TENANT_ID,
UserGroupInformation.getCurrentUser.getShortUserName)
}
+
+ override def provide(): UserIdentifier = {
+ provideUserIdentifier()
+ }
+
Review Comment:
I dont think that would be backward compatible. If users would have created
their own identity providers, changing the provide function to accept the
CelebornConf object would result in failures on their end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
