RexXiong commented on code in PR #3214:
URL: https://github.com/apache/celeborn/pull/3214#discussion_r2055302120
##########
common/src/main/scala/org/apache/celeborn/common/util/Utils.scala:
##########
@@ -613,7 +613,7 @@ object Utils extends Logging {
}
}
- def instantiateDynamicConfigStoreBackend[T](className: String, conf:
CelebornConf): T = {
+ def instantiateClassWithCelebornConf[T](className: String, conf:
CelebornConf): T = {
Review Comment:
nit: Need also change exception message when throw `CelebornException`
##########
common/src/main/scala/org/apache/celeborn/common/identity/IdentityProvider.scala:
##########
@@ -30,6 +30,15 @@ object IdentityProvider extends Logging {
val DEFAULT_USERNAME = "default"
def instantiate(conf: CelebornConf): IdentityProvider = {
- Utils.instantiate[IdentityProvider](conf.identityProviderClass)
+ val className = conf.identityProviderClass
+ logDebug(s"Creating instance of $className")
+
+ try {
Review Comment:
nit: Seems we can remove try-catch block now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
