s0nskar opened a new pull request, #3675:
URL: https://github.com/apache/celeborn/pull/3675
…upt shuffle
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Fix backward compatibility issue with interrupt shuffle by checking if the
reason is nonEmpty.
### Why are the changes needed?
If someone uses a new client with old server which is not sending
`CheckQuotaResponse` in `HeartbeatFromApplicationResponse` then proto uses
default value to build CheckQuotaResponse with isAvailable=false and reason="".
In this case the job will always fails without breaching the quota, we should
not fail the job if the reason is empty to make it backward compatible.
### Does this PR resolve a correctness bug?
<!-- Yes/No. (Note: If yes, committer will add `correctness` label to
current pull request). -->
No
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Tested in local setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
