RexXiong commented on PR #3675: URL: https://github.com/apache/celeborn/pull/3675#issuecomment-4394158546
Using `reason.nonEmpty` as a proxy for "server supports quota check" is fragile — `reason` is a business description field, not a compatibility signal. If a legitimate quota-exceeded response happens to have an empty reason, it would be silently ignored; conversely, any future change to the reason format could break this logic. Since `quotaInterruptShuffleEnabled` defaults to `false`, users must explicitly opt in. In a new-client/old-server scenario, users should simply not enable this config. This is an explicit and semantically clear approach, rather than relying on an implicit convention around the `reason` field. If we do need robust backward compatibility, a better approach would be to add an explicit capability field (e.g., `quotaCheckSupported`) to the heartbeat response. But that's a larger change and can be addressed separately. — *Reviewed by [Claude Code](https://claude.com/claude-code)* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
