SteNicholas commented on code in PR #3675:
URL: https://github.com/apache/celeborn/pull/3675#discussion_r3223337803
##########
client/src/main/scala/org/apache/celeborn/client/ApplicationHeartbeater.scala:
##########
@@ -164,7 +164,7 @@ class ApplicationHeartbeater(
}
private def checkQuotaExceeds(response: CheckQuotaResponse): Unit = {
- if (conf.quotaInterruptShuffleEnabled && !response.isAvailable) {
+ if (conf.quotaInterruptShuffleEnabled && !response.isAvailable &&
response.reason.nonEmpty) {
Review Comment:
It's better to introduce new field like `quotaCheckSupported` to fix
backward compatiblity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
