gauravkm commented on PR #3856: URL: https://github.com/apache/celeborn/pull/3856#issuecomment-5941858547
I meant that `testPushRetryBackoff` calls `pushRetryBackoffMs()` directly: it checks the calculated delay, but does not exercise the push callback and scheduled retry together. For example, a focused test could trigger a failed/HARD_SPLIT push with jitter disabled, check the scheduled delay, then control revive completion and verify that successful completion clears the tracked batch or exhausted retries surface the expected failure. Single pushes calculate the revive deadline before scheduling; merged pushes calculate it inside the scheduled task, so revive completion during backoff versus remaining pending at the deadline are useful cases to cover. This was a coverage suggestion, not a newly identified correctness issue. The helper and latch tests you added are useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
