gauravkm commented on PR #3856: URL: https://github.com/apache/celeborn/pull/3856#issuecomment-5960036111
Looks good from the code review; no P0/P1 issues found. I checked that the shared scheduling helper preserves all five retry paths. The new tests address the callback-wiring part of my suggestion: they check the requested 100 ms delay, complete revive before invoking the captured retry, and verify both single and merged resends, plus single-push cleanup. Deadline expiry and retry exhaustion remain outside this coverage. CI currently shows passing label checks only; seven workflows await maintainer approval, so there are no build/test results yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
