zaynt4606 commented on PR #3856: URL: https://github.com/apache/celeborn/pull/3856#issuecomment-6095856357
Thanks for adding the retry tests. I noticed two remaining edge cases: 1. `pushRetryBackoffMs()` caps the base delay before applying jitter. With `backoff.max=10s` and the default jitter of `0.5`, the scheduled delay can reach 15s. Could we cap the final delay and test jitter at the cap, or clarify that `backoff.max` only bounds the base delay? 2. `checkDiskFullAndSplit()` still logs memory-shuffle `HARD_SPLIT` at INFO on every call. The new `shouldLogHardSplit()` guard only covers the disk-file branch. Could we apply it to the memory branch as well and test repeated calls? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
