[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551837#comment-14551837
 ] 

Wilder Rodrigues commented on CLOUDSTACK-8486:
----------------------------------------------

Fixing the testGetHostStatsCommand test under LibvirtComputingResourceTest. - 
Removed the expected value from the Test annotation - Mocking the bash path in 
order to avoid environment/OS issues

Fixing typo on LibvirtRequestWrapper
  - Replace linbvirtCommands by libvirtCommands on LibvirtRequestWrapper

https://github.com/apache/cloudstack/commit/0cdb4b610865fa5493cc79e9c9ef310bdf09ccaf

> Refactoring LibVirt (KVM) Hypervisor Plugin
> -------------------------------------------
>
>                 Key: CLOUDSTACK-8486
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8486
>             Project: CloudStack
>          Issue Type: Improvement
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>          Components: KVM
>    Affects Versions: 4.5.0
>            Reporter: Wilder Rodrigues
>            Assignee: Wilder Rodrigues
>             Fix For: 4.6.0
>
>
> The main goal behind this refactor is to reduce the amount of code in the 
> LibvirtComputingResource class and also all the nested IFs that it has in the 
> executeRequest() method (67 in total).
> The same approach used in the CitrixResourceBase refactoring will be applied 
> here.
> In addition, for each method extracted from the LibvirtComputingResource into 
> a wrapper, a unit test will be created.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to