[
https://issues.apache.org/jira/browse/CLOUDSTACK-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551856#comment-14551856
]
ASF GitHub Bot commented on CLOUDSTACK-8486:
--------------------------------------------
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/266
CLOUDSTACK-8486: Refactoring LibVirt (KVM) Hypervisor Plugin
Hi @bhaisaab and @DaanHoogland
There goes a PR to fix JDK 1.8 build (whenever use start using them)
Changing the JUnit runner in order to avoid problems with Java 8
- All tests passed using different approaches
- Maven with parameters: -Dmaven.compiler.source=1.8
-Dmaven.compiler.target=1.8
- Maven without parameters
All builds were executed using javac 1.8.0_31
Parameterising a hardcoded timeout of 10000 milli seconds.
- This timeout was hanging when running the unit tests (3, in total)
- The value is now mocked and 1 is returned instead of 10000
Environment:
Centos7 + KVM + Qemu
MySQL/MariaDB 5.5.41
Management Server running CentOS 7
Component/Smoke tests: https://github.com/apache/cloudstack
(test/integration/component and smoke)
Storage type: NFS shared
Isolation method: VLAN
Test Create Account and user for that account ... === TestName:
test_01_create_account | Status : SUCCESS ===
ok
Test Sub domain allowed to launch VM when a Domain ... === TestName:
test_01_add_vm_to_subdomain | Status : SUCCESS ===
ok
Test delete domain without force option ... === TestName: test_DeleteDomain
| Status : SUCCESS ===
ok
Test delete domain with force option ... === TestName:
test_forceDeleteDomain | Status : SUCCESS ===
ok
Test to verify Non Root admin previleges ... === TestName:
test_01_non_root_admin_Privileges | Status : SUCCESS ===
ok
Test Remove one user from the account ... === TestName:
test_01_user_remove_VM_running | Status : SUCCESS ===
ok
Test to verify service offerings at same level in hierarchy ... ===
TestName: test_01_service_offering_hierarchy | Status : SUCCESS ===
ok
Test to verify service offerings at same level in hierarchy ... ===
TestName: test_01_service_offering_siblings | Status : SUCCESS ===
ok
Test to verify template at same level in hierarchy ... === TestName:
test_01_template_hierarchy | Status : SUCCESS ===
ok
Test update admin details ... === TestName: test_updateAdminDetails |
Status : SUCCESS ===
ok
Test update domain admin details ... === TestName:
test_updateDomainAdminDetails | Status : SUCCESS ===
ok
Test user update API ... === TestName: test_updateUserDetails | Status :
SUCCESS ===
ok
Test login API with domain ... === TestName: test_LoginApiDomain | Status :
SUCCESS ===
ok
Test if Login API does not return UUID's ... === TestName:
test_LoginApiUuidResponse | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 14 tests in 7907.566s
OK
/tmp//MarvinLogs/test_accounts_D6DDT5/results.txt
Test advanced zone virtual router ... === TestName:
test_advZoneVirtualRouter | Status : SUCCESS ===
ok
Test Deploy Virtual Machine ... === TestName: test_deploy_vm | Status :
SUCCESS ===
ok
Test Multiple Deploy Virtual Machine ... === TestName:
test_deploy_vm_multiple | Status : SUCCESS ===
ok
Test Stop Virtual Machine ... === TestName: test_01_stop_vm | Status :
SUCCESS ===
ok
Test Start Virtual Machine ... === TestName: test_02_start_vm | Status :
SUCCESS ===
ok
Test Reboot Virtual Machine ... === TestName: test_03_reboot_vm | Status :
SUCCESS ===
ok
Test destroy Virtual Machine ... === TestName: test_06_destroy_vm | Status
: SUCCESS ===
ok
Test recover Virtual Machine ... === TestName: test_07_restore_vm | Status
: SUCCESS ===
ok
Test migrate VM ... SKIP: At least two hosts should be present in the zone
for migration
Test destroy(expunge) Virtual Machine ... === TestName: test_09_expunge_vm
| Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 10 tests in 2997.472s
OK (SKIP=1)
/tmp//MarvinLogs/test_vm_life_cycle_KWTICX/results.txt
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schubergphilis/cloudstack
improvement/java_8_compliant
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #266
----
commit 754a0992eed37915beca6c39b6d2af9ea7e73f4a
Author: wilderrodrigues <[email protected]>
Date: 2015-05-18T14:24:00Z
Changing the JUnit runner in order to avoid problems with Java 8
- All tests passed using different approaches
- Maven with parameters: -Dmaven.compiler.source=1.8
-Dmaven.compiler.target=1.8
- Maven without parameters
All builds were executed using javac 1.8.0_31
commit 13c5f2131767a2cc76482018fb055d81aea66d92
Author: wilderrodrigues <[email protected]>
Date: 2015-05-18T14:24:00Z
Changing the JUnit runner in order to avoid problems with Java 8
- All tests passed using different approaches
- Maven with parameters: -Dmaven.compiler.source=1.8
-Dmaven.compiler.target=1.8
- Maven without parameters
All builds were executed using javac 1.8.0_31
commit 51be19987ac1604989689881e20920787e85b5c4
Author: wilderrodrigues <[email protected]>
Date: 2015-05-19T05:11:04Z
Merge remote-tracking branch
'refs/remotes/origin/improvement/java_8_compliant' into
improvement/java_8_compliant
commit 1fce40cb7aefccf065f1218a11e55da4955978c8
Author: wilderrodrigues <[email protected]>
Date: 2015-05-19T17:59:09Z
Parameterising a hardcoded timeout of 10000 milli seconds.
- This timeout was hanging when running the unit tests (3, in total)
- The value is now mocked and 1 is returned insteado of 10000
commit e25f9ccf152bdef762ec38a6128f4e9b175bfc61
Author: wilderrodrigues <[email protected]>
Date: 2015-05-18T14:24:00Z
Changing the JUnit runner in order to avoid problems with Java 8
- All tests passed using different approaches
- Maven with parameters: -Dmaven.compiler.source=1.8
-Dmaven.compiler.target=1.8
- Maven without parameters
All builds were executed using javac 1.8.0_31
commit 34846dc30496627b14a2ec531f28021f7e7580b0
Author: wilderrodrigues <[email protected]>
Date: 2015-05-19T17:59:09Z
Parameterising a hardcoded timeout of 10000 milli seconds.
- This timeout was hanging when running the unit tests (3, in total)
- The value is now mocked and 1 is returned insteado of 10000
commit 61ae1a35da3a531ba59d2d6392da68d8614bfcf2
Author: wilderrodrigues <[email protected]>
Date: 2015-05-20T05:30:42Z
Merge remote-tracking branch
'refs/remotes/origin/improvement/java_8_compliant' into
improvement/java_8_compliant
Rebasing this branch based on latest master before creating PR
----
> Refactoring LibVirt (KVM) Hypervisor Plugin
> -------------------------------------------
>
> Key: CLOUDSTACK-8486
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8486
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: KVM
> Affects Versions: 4.5.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>
> The main goal behind this refactor is to reduce the amount of code in the
> LibvirtComputingResource class and also all the nested IFs that it has in the
> executeRequest() method (67 in total).
> The same approach used in the CitrixResourceBase refactoring will be applied
> here.
> In addition, for each method extracted from the LibvirtComputingResource into
> a wrapper, a unit test will be created.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
