[
https://issues.apache.org/jira/browse/CLOUDSTACK-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14552281#comment-14552281
]
ASF GitHub Bot commented on CLOUDSTACK-8486:
--------------------------------------------
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/270
CLOUDSTACK-8486
@bhaisaab and @DaanHooglan, there goes another one.
It has only unit tests changes, so not a big deal with integration tests.
The Libvirt tests are running in 2.889 sec in the KVM environment, instead of
257.879 sec
Removing real IPs from the tests because they cause a long running time for
LibvirtComputingResourceTest
- In a local machine it takes 1.977s, but in a KVM test environment
it's taking 257.879 sec
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/schubergphilis/cloudstack
fix/libvirt_unittests_timeout
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #270
----
commit 982a0235a0143864e5b0eda1836fb913d91252f6
Author: wilderrodrigues <[email protected]>
Date: 2015-05-20T12:52:08Z
CLOUDSTACK-8486
Removing real IPs from the tests because they cause a long running time
for LibvirtComputingResourceTest
- In a local machine it takes 1.977s, but in a KVM test environment
it's taking 257.879 sec
----
> Refactoring LibVirt (KVM) Hypervisor Plugin
> -------------------------------------------
>
> Key: CLOUDSTACK-8486
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-8486
> Project: CloudStack
> Issue Type: Improvement
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Components: KVM
> Affects Versions: 4.5.0
> Reporter: Wilder Rodrigues
> Assignee: Wilder Rodrigues
> Fix For: 4.6.0
>
>
> The main goal behind this refactor is to reduce the amount of code in the
> LibvirtComputingResource class and also all the nested IFs that it has in the
> executeRequest() method (67 in total).
> The same approach used in the CitrixResourceBase refactoring will be applied
> here.
> In addition, for each method extracted from the LibvirtComputingResource into
> a wrapper, a unit test will be created.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
