[
https://issues.apache.org/jira/browse/LANG-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529013
]
Christoph Kutzinski commented on LANG-353:
------------------------------------------
Yes, that's what I'm suggesting.
And if I understood your second point right - you are suggesting to compare the
class names, because the two objects could be loaded in different classloaders:
No, if two classes are loaded by different classloaders, they (and their
instances) are never "equal". Even if they are loaded from the same source,
i.e. the same .class file.
> Javadoc Example for EqualsBuilder is questionable
> -------------------------------------------------
>
> Key: LANG-353
> URL: https://issues.apache.org/jira/browse/LANG-353
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Christoph Kutzinski
> Priority: Minor
> Fix For: 2.4
>
>
> The Javadoc example for the class EqualsBuilder ist questionable:
> public boolean equals(Object obj) {
> if (obj instanceof MyClass == false) {
> return false;
> }
> ...
> The implementation with instanceof lacks guarantees like equals-symmetry
> (see e.g. http://www.agiledeveloper.com/articles/equals062002.htm for a
> discussion of the issue)
> The example should be changed to use getClass(). Attention: the solution in
> the link above is incomplete as it doesn't check for null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
