[
https://issues.apache.org/jira/browse/LANG-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537846
]
Henri Yandell commented on LANG-353:
------------------------------------
Oops, this has sat on my machine for a while. Now committed:
svn ci -m "Applying the javadoc sample usage change from LANG-353 as reported
by Christoph Kutzinski"
src/java/org/apache/commons/lang/builder/EqualsBuilder.java
Sending src/java/org/apache/commons/lang/builder/EqualsBuilder.java
Transmitting file data .
Committed revision 588536.
Prior to closing this, I'm pondering if the EqualsBuilderTest should change to
test this pattern too.
> Javadoc Example for EqualsBuilder is questionable
> -------------------------------------------------
>
> Key: LANG-353
> URL: https://issues.apache.org/jira/browse/LANG-353
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Christoph Kutzinski
> Priority: Minor
> Fix For: 2.4
>
>
> The Javadoc example for the class EqualsBuilder ist questionable:
> public boolean equals(Object obj) {
> if (obj instanceof MyClass == false) {
> return false;
> }
> ...
> The implementation with instanceof lacks guarantees like equals-symmetry
> (see e.g. http://www.agiledeveloper.com/articles/equals062002.htm for a
> discussion of the issue)
> The example should be changed to use getClass(). Attention: the solution in
> the link above is incomplete as it doesn't check for null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
