[
https://issues.apache.org/jira/browse/LANG-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529363
]
Christoph Kutzinski commented on LANG-353:
------------------------------------------
Ok.
Do you have an issue id for the Enum thing? My opinion on that - without
knowing the details - is that Enums are not much different from classes and
therefore enums from different classloaders shouldn't be considered equals. So,
I would like to comment on that issue.
> Javadoc Example for EqualsBuilder is questionable
> -------------------------------------------------
>
> Key: LANG-353
> URL: https://issues.apache.org/jira/browse/LANG-353
> Project: Commons Lang
> Issue Type: Bug
> Reporter: Christoph Kutzinski
> Priority: Minor
> Fix For: 2.4
>
>
> The Javadoc example for the class EqualsBuilder ist questionable:
> public boolean equals(Object obj) {
> if (obj instanceof MyClass == false) {
> return false;
> }
> ...
> The implementation with instanceof lacks guarantees like equals-symmetry
> (see e.g. http://www.agiledeveloper.com/articles/equals062002.htm for a
> discussion of the issue)
> The example should be changed to use getClass(). Attention: the solution in
> the link above is incomplete as it doesn't check for null
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
