[ 
https://issues.apache.org/jira/browse/COMMONSSITE-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12552000
 ] 

Niall Pemberton commented on COMMONSSITE-21:
--------------------------------------------

Dennis,

Didn't know about the "skip parameter" - wouldn't that mean a component would 
need to add "rc" and "release" profiles to their poms with config for the 
plugin in each?

I had a look at remote resources plugin and found out it does actually ignore a 
remote resource if a resource of the same name is already specified in the 
project. Unfortunately its generating a "Notice" file rather than a 
"Notice.txt" file. I tried renaming the Validator one to "Notice" (and 
specifying that in the pom) and it picked up the Validator one rather than 
generating.

These Notice and License files are being generated by the plugin from velocity 
templates in the apache-jar-resource-bundle-1.3.jar. If those templates had 
been named Notice.txt.vm and License.txt.vm (rather than Notice.vm and 
License.vm) then the plugin would generate Notice.txt and License.txt files (I 
think) and then any component could either use the generated one or override by 
adding Notice/License files. That seems a much easier/straight forward way to 
me.

So I guess possible solutions  (to duplicate entries and people overriding 
where required)  are:

1) rename the velocity templates in apache-jar-resource-bundle-1.3.jar
2) create another jar resource bundle containing alternative named 
license/notice velocity templates
3) Rename all Notice.txt/License.txt files in commons to Notice/License
4) Remove the remote resources plugin

I would quite like to release version 6 of commons-parent so that we have a 
version with the latest commons-skin (and therefore m2 sites generate with the 
ApacheCon logo) and to avoid the profile issues I had. How about we opt 
initially for option 4) and remove the remote-resources-plugin and release 
commons-parent-6. If/When we have agreement on another solution using that 
plugin we can put it back in when its ready.

> commons-parent-6 pom changes
> ----------------------------
>
>                 Key: COMMONSSITE-21
>                 URL: https://issues.apache.org/jira/browse/COMMONSSITE-21
>             Project: Commons All
>          Issue Type: Improvement
>          Components: Commons Parent Pom
>            Reporter: Niall Pemberton
>         Attachments: commons-valdiator-generated-NOTICE.txt, 
> COMMONSSITE-21-commons-parent-pom-v1.patch, 
> COMMONSSITE-21-commons-parent-pom-v2.patch
>
>
> Opening this ticket to discuss changes for Version 6 of the commons-parent 
> pom.
> See thread: http://tinyurl.com/39eo9z for related discussion/issues

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to