[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17326883#comment-17326883
]
Matt Juntunen commented on NUMBERS-77:
--------------------------------------
bq. PR#88 fails the build.
Yes, I'm not sure what that's about. The failure says that a git commit is
missing:
{code}
Caused by: org.eclipse.jgit.errors.MissingObjectException: Missing commit
99c627e57e5bb14ada31f33809aa62356bfbb7bd
at org.eclipse.jgit.storage.file.WindowCursor.open (WindowCursor.java:126)
at org.eclipse.jgit.revwalk.RevWalk.getCachedBytes (RevWalk.java:856)
{code}
bq. Name is not very self-descriptive (despite its length).
Any suggestions? I've been using this class for so long I can't picture it as
anything else.
bq. Make it an interface (instead of an abstract class)?
Sure.
bq. Make a factory method in Precision class?
Sure.
bq. Is it ever used through Comparator<Double>? If so, isn't there a potential
performance issue because of automatic boxing/unboxing.
I believe that only the primitive {{compare}} method is used. It seemed like
since we had the primitive method in place that we should go ahead and
implement the actual {{Comparator}} interface.
> Move utilities from "Commons Geometry"
> --------------------------------------
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
> Reporter: Gilles Sadowski
> Priority: Major
> Fix For: 1.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
