[
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329342#comment-17329342
]
Matt Juntunen commented on NUMBERS-77:
--------------------------------------
bq. So if we agree on the basic design, I could merge the current version (as
per the attached diff). OK?
Yes, but I have a couple more points:
- I'm not sold on the name yet (see below).
- I would prefer if the interface were top-level instead of nested in
{{Precision}}. It makes it more convenient since this type will be used almost
everywhere in geometry.
bq. I feel that it doesn't say what the class does.
It's the same with the {{Precision}} class in general. I like having the term
"precision" in the name since you immediately know that you're going to be
working with floating point accuracy. My favorite names so far are (in order):
- {{PrecisionContext}}
- {{PrecisionComparator}}
- {{PrecisionCompareStrategy}}
(I'm probably a bit biased here, though, since if the name doesn't have
"precision" in it, I'm going to need to update about a bajillion variable names
and javadocs in geometry :-)
> Move utilities from "Commons Geometry"
> --------------------------------------
>
> Key: NUMBERS-77
> URL: https://issues.apache.org/jira/browse/NUMBERS-77
> Project: Commons Numbers
> Issue Type: Task
> Reporter: Gilles Sadowski
> Priority: Major
> Fix For: 1.1
>
> Attachments: NUMBERS-77.diff
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit
> from consolidated usage (bug reporting, performance enhancements, ...).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
