[ 
https://issues.apache.org/jira/browse/NUMBERS-77?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329202#comment-17329202
 ] 

Gilles Sadowski commented on NUMBERS-77:
----------------------------------------

bq. [interface with default methods] is much cleaner.

So if we agree on the basic design, I could merge the current version (as per 
the attached diff). OK?

bq. Are we sure that PrecisionContext isn't the best option?

I feel that it doesn't say *what* the class does.

bq. I was picturing this as an easy way to compare to zero. [...]  handling of 
-0.0 [...] is entirely up to the implementation.

It's potentially confusing (giving the false sense that it can be used wherever 
"signum" would be).

bq. It's essentially a signum but returning an int for strict equality checking 
(eg, cmp == 0).

It can be done the same with the return type being {{double}} (and the 
appropriate comment that a strict equality check is done on purpose).


> Move utilities from "Commons Geometry"
> --------------------------------------
>
>                 Key: NUMBERS-77
>                 URL: https://issues.apache.org/jira/browse/NUMBERS-77
>             Project: Commons Numbers
>          Issue Type: Task
>            Reporter: Gilles Sadowski
>            Priority: Major
>             Fix For: 1.1
>
>         Attachments: NUMBERS-77.diff
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> "Commons Geometry" defines utilities that would be a better fit in this 
> component.
> Duplication of general-purpose codes should be avoided, in order to benefit 
> from consolidated usage (bug reporting, performance enhancements, ...).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to