rmannibucau commented on a change in pull request #71:
URL: https://github.com/apache/commons-jcs/pull/71#discussion_r705913097
##########
File path:
commons-jcs-jcache/src/main/java/org/apache/commons/jcs3/jcache/JCSCachingManager.java
##########
@@ -189,8 +189,8 @@ private void assertNotClosed()
assertNotClosed();
assertNotNull(cacheName, "cacheName");
assertNotNull(configuration, "configuration");
- final Class<?> keyType = configuration == null ? Object.class :
configuration.getKeyType();
Review comment:
Expected pattern was `final var foo = a == null ? defaultvalue : a`.
Here the default is object class so the configuration == null should be
replaced by configuration.getKeyType() or configuration.getValueType() I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
