[
https://issues.apache.org/jira/browse/LANG-1675?focusedWorklogId=663168&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-663168
]
ASF GitHub Bot logged work on LANG-1675:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/21 11:29
Start Date: 09/Oct/21 11:29
Worklog Time Spent: 10m
Work Description: XenoAmess commented on pull request #812:
URL: https://github.com/apache/commons-lang/pull/812#issuecomment-939281213
> Reading through this, I wonder whether we should deprecate StringJoiner?
>
>
> On Sat, Oct 9, 2021 at 12:55 PM Hubert ***@***.***> wrote:
>
> > This PR replaces StringJoiner to StringBuilder in StringUtils.join
methods.
> > The change is limited to methods which use primitives as input only.
> > More
> >
> > Please find more details here:
> >
> > 1. https://issues.apache.org/jira/browse/LANG-1675
> > 2.#784 <https://github.com/apache/commons-lang/pull/784>
> >
> > JMH with example results
> >
> > JMH tests - StringBuilder vs StringJoiner may be found in dedicated
> > repository:
> > https://github.com/HubertWo/apache-commons-lang-jmh
> > ------------------------------
> > You can view, comment on, or merge this pull request online at:
> >
> > https://github.com/apache/commons-lang/pull/812
> > Commit Summary
> >
> > - String.join - boolean - use StringBuilder
> >
<https://github.com/apache/commons-lang/pull/812/commits/db16c588f6a5730cff13bbf9e4196f8cfbb1f763>
> > - Replaced StringJoiner by StringBuilder
> >
<https://github.com/apache/commons-lang/pull/812/commits/e31a7230c50708f342e5797e70849d404cca0431>
> > - Fix: formatting, removed condition in for
> >
<https://github.com/apache/commons-lang/pull/812/commits/1fe3e64bc0fac8afa33fea2f4a36a7f264bb1704>
> > - Merge branch 'apache:master' into fix/LANG-1675_string_join_refactor
> >
<https://github.com/apache/commons-lang/pull/812/commits/f2f6cd9b0580f25a3a5447da092ac30642abd2aa>
> >
> > File Changes
> >
> > - *M* src/main/java/org/apache/commons/lang3/StringUtils.java
> >
<https://github.com/apache/commons-lang/pull/812/files#diff-dc0df3da8c3d510794ee168c3bbe26fb19707732391dbd9e8a19d26033df5eb7>
> > (96)
> >
> > Patch Links:
> >
> > - https://github.com/apache/commons-lang/pull/812.patch
> > - https://github.com/apache/commons-lang/pull/812.diff
> >
> > —
> > You are receiving this because you are subscribed to this thread.
> > Reply to this email directly, view it on GitHub
> > <https://github.com/apache/commons-lang/pull/812>, or unsubscribe
> >
<https://github.com/notifications/unsubscribe-auth/AAIBUGKXBC2IUTE2Z7IGCG3UGANTNANCNFSM5FVFOPNA>
> > .
> > Triage notifications on the go with GitHub Mobile for iOS
> >
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> > or Android
> >
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
> >
> >
>
>
> --
>
> Look, that's why there's rules, understand? So that you think before
> you break 'em.
>
> -- (Terry Pratchett, Thief of Time)
>
agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 663168)
Time Spent: 40m (was: 0.5h)
> Improve performance of StringUtils.join for primitives.
> -------------------------------------------------------
>
> Key: LANG-1675
> URL: https://issues.apache.org/jira/browse/LANG-1675
> Project: Commons Lang
> Issue Type: Improvement
> Reporter: Hubert Wojciechowski
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This is [~XenoAmess] comment from PR:
> [https://github.com/apache/commons-lang/pull/784]
> {noformat}
> Please look at the sources in JDK, where
> java.lang.AbstractStringBuilder#append(boolean b)
> In short, for basic types, should not convert them to String, but use
> StringBuilder directly, will bring far better performance.
> BUT I just foundout that you did not bring this issue, this issue is already
> in commons-lang before your pr.
> So I will not stop you from merging this in, but still I will find time to
> refactor the whole join serial functions later.
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
