[
https://issues.apache.org/jira/browse/LANG-1675?focusedWorklogId=682644&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-682644
]
ASF GitHub Bot logged work on LANG-1675:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/21 14:27
Start Date: 17/Nov/21 14:27
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #812:
URL: https://github.com/apache/commons-lang/pull/812#issuecomment-971633044
@HubertWo
Hm, I'm not sure how you ran your benchmarks, I had to hack the POM like we
do in Commons IO to be able to run "mvn clean test".
May you please update the project to remove the Java 17 requirement and make
the benchmarks runnable from the command line? I'd like to just run a Maven
command (however you want to set it up) and then post my results here so we can
compare results.
TY!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 682644)
Time Spent: 1h 50m (was: 1h 40m)
> Improve performance of StringUtils.join for primitives.
> -------------------------------------------------------
>
> Key: LANG-1675
> URL: https://issues.apache.org/jira/browse/LANG-1675
> Project: Commons Lang
> Issue Type: Improvement
> Reporter: Hubert Wojciechowski
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> This is [~XenoAmess] comment from PR:
> [https://github.com/apache/commons-lang/pull/784]
> {noformat}
> Please look at the sources in JDK, where
> java.lang.AbstractStringBuilder#append(boolean b)
> In short, for basic types, should not convert them to String, but use
> StringBuilder directly, will bring far better performance.
> BUT I just foundout that you did not bring this issue, this issue is already
> in commons-lang before your pr.
> So I will not stop you from merging this in, but still I will find time to
> refactor the whole join serial functions later.
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
