[
https://issues.apache.org/jira/browse/LANG-1675?focusedWorklogId=682837&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-682837
]
ASF GitHub Bot logged work on LANG-1675:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/21 18:02
Start Date: 17/Nov/21 18:02
Worklog Time Spent: 10m
Work Description: HubertWo edited a comment on pull request #812:
URL: https://github.com/apache/commons-lang/pull/812#issuecomment-971821103
Hi @garydgregory
Thank you for your time.
I removed Java 17 dependencies. Now everything works agains Java 8.
Also it's possible to run benchmarks from command line - exactly the same as
described in the official JMH doc.
Please find run instructions and example results here:
1.
https://github.com/HubertWo/apache-commons-lang-jmh/tree/main/string-joiner
2.
https://github.com/HubertWo/apache-commons-lang-jmh/tree/main/string-builder
I have also added GitHub Action that built and ran string-joiner benchmark
agains Java 8.
Please find logs here:
https://github.com/HubertWo/apache-commons-lang-jmh/runs/4241475267?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 682837)
Time Spent: 2h 10m (was: 2h)
> Improve performance of StringUtils.join for primitives.
> -------------------------------------------------------
>
> Key: LANG-1675
> URL: https://issues.apache.org/jira/browse/LANG-1675
> Project: Commons Lang
> Issue Type: Improvement
> Reporter: Hubert Wojciechowski
> Priority: Minor
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> This is [~XenoAmess] comment from PR:
> [https://github.com/apache/commons-lang/pull/784]
> {noformat}
> Please look at the sources in JDK, where
> java.lang.AbstractStringBuilder#append(boolean b)
> In short, for basic types, should not convert them to String, but use
> StringBuilder directly, will bring far better performance.
> BUT I just foundout that you did not bring this issue, this issue is already
> in commons-lang before your pr.
> So I will not stop you from merging this in, but still I will find time to
> refactor the whole join serial functions later.
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
