[
https://issues.apache.org/jira/browse/LANG-1675?focusedWorklogId=683933&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683933
]
ASF GitHub Bot logged work on LANG-1675:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/21 13:03
Start Date: 19/Nov/21 13:03
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #812:
URL: https://github.com/apache/commons-lang/pull/812#issuecomment-974053312
@kinow Your results are not that helpful IMO because you're are not
measuring useful runs, you've effectively invented new tests and new
methodology :( I was able to follow the instructions from @HubertWo without
issue, please see his docs.
My impression is that you are measuring so little that there is too much
risk for noise: In your tests, you are measuring throughput in _hundredths_ of
operations per _nanoseconds_. In @HubertWo's setup, you measure _millions_ of
operations per _second_. Unless you are running on some LN2-cooled CPU and the
rest of us on potatoes, I'm not sure how to account for the difference aside
from simply running the tests in a completely different way. As soon as you
start editing the sources and changing the JMH annotations, making a simple
comparison is hopeless.
Please do take the time to review @HubertWo's docs, it worked after I took
the time to follow his readme, nothing special to do. Otherwise, do post what
your issue is, I am sure we will all benefit from learning how to deal with JMH
better ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683933)
Time Spent: 3.5h (was: 3h 20m)
> Improve performance of StringUtils.join for primitives.
> -------------------------------------------------------
>
> Key: LANG-1675
> URL: https://issues.apache.org/jira/browse/LANG-1675
> Project: Commons Lang
> Issue Type: Improvement
> Reporter: Hubert Wojciechowski
> Priority: Minor
> Time Spent: 3.5h
> Remaining Estimate: 0h
>
> This is [~XenoAmess] comment from PR:
> [https://github.com/apache/commons-lang/pull/784]
> {noformat}
> Please look at the sources in JDK, where
> java.lang.AbstractStringBuilder#append(boolean b)
> In short, for basic types, should not convert them to String, but use
> StringBuilder directly, will bring far better performance.
> BUT I just foundout that you did not bring this issue, this issue is already
> in commons-lang before your pr.
> So I will not stop you from merging this in, but still I will find time to
> refactor the whole join serial functions later.
> {noformat}
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
