[
https://issues.apache.org/jira/browse/DBCP-589?focusedWorklogId=834061&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-834061
]
ASF GitHub Bot logged work on DBCP-589:
---------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/22 07:14
Start Date: 16/Dec/22 07:14
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354314617
#
[Codecov](https://codecov.io/gh/apache/commons-dbcp/pull/248?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Report
> Merging
[#248](https://codecov.io/gh/apache/commons-dbcp/pull/248?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(ae20eda) into
[master](https://codecov.io/gh/apache/commons-dbcp/commit/2008276a484d101d789f01bba68b444103a0eb4f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
(2008276) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #248 +/- ##
============================================
- Coverage 59.72% 59.71% -0.02%
Complexity 1783 1783
============================================
Files 57 57
Lines 7417 7417
Branches 421 421
============================================
- Hits 4430 4429 -1
- Misses 2770 2771 +1
Partials 217 217
```
| [Impacted
Files](https://codecov.io/gh/apache/commons-dbcp/pull/248?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
| Coverage Δ | |
|---|---|---|
|
[...ache/commons/dbcp2/managed/TransactionContext.java](https://codecov.io/gh/apache/commons-dbcp/pull/248/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2NvbW1vbnMvZGJjcDIvbWFuYWdlZC9UcmFuc2FjdGlvbkNvbnRleHQuamF2YQ==)
| `72.22% <0.00%> (-1.86%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD
build times. [Learn
more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
Issue Time Tracking
-------------------
Worklog Id: (was: 834061)
Time Spent: 20m (was: 10m)
> Provide Jakarta namespace ready artifact of DBCP2
> -------------------------------------------------
>
> Key: DBCP-589
> URL: https://issues.apache.org/jira/browse/DBCP-589
> Project: Commons DBCP
> Issue Type: Bug
> Affects Versions: 2.9.0
> Reporter: Richard Zowalla
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, we are using a shaded and relocated version of DBCP2 in TomEE to
> have a Jakarta namespace variant of DBCP2.
> For DBCP2 it would require to do some small relocations:
> {code:xml}
> <relocations>
> <relocation>
> <pattern>javax.transaction</pattern>
> <shadedPattern>jakarta.transaction</shadedPattern>
> <excludes>
> <exclude>javax.transaction.xa.**</exclude>
> </excludes>
> </relocation>
> </relocations>
> {code}
> Geronimo and other EE related projects are using the relocation / shade
> approach to provide artifacts via a "jakarta" classifier.
> I will open a related PR soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
