[
https://issues.apache.org/jira/browse/DBCP-589?focusedWorklogId=834083&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-834083
]
ASF GitHub Bot logged work on DBCP-589:
---------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/22 08:27
Start Date: 16/Dec/22 08:27
Worklog Time Spent: 10m
Work Description: rmannibucau commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354381686
+1 to get it in or switch now (I know it is a bit early and it is not
justified to get 2 "main" branches).
Note that if it helps adding a test is very feasible - we do at openwebbeans
for ex - and enforcing binary compatiblity can be done too even if quite
useless for this particular project (guess a test is a very good compromise
since it will validate both at once).
The only change I would do is to relocate `org.apache.commons.dbcp2` in
`org.apache.commons.dbcp2.jakarta` to ensure both can run together - yes it
happens.
Issue Time Tracking
-------------------
Worklog Id: (was: 834083)
Time Spent: 50m (was: 40m)
> Provide Jakarta namespace ready artifact of DBCP2
> -------------------------------------------------
>
> Key: DBCP-589
> URL: https://issues.apache.org/jira/browse/DBCP-589
> Project: Commons DBCP
> Issue Type: Bug
> Affects Versions: 2.9.0
> Reporter: Richard Zowalla
> Priority: Minor
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently, we are using a shaded and relocated version of DBCP2 in TomEE to
> have a Jakarta namespace variant of DBCP2.
> For DBCP2 it would require to do some small relocations:
> {code:xml}
> <relocations>
> <relocation>
> <pattern>javax.transaction</pattern>
> <shadedPattern>jakarta.transaction</shadedPattern>
> <excludes>
> <exclude>javax.transaction.xa.**</exclude>
> </excludes>
> </relocation>
> </relocations>
> {code}
> Geronimo and other EE related projects are using the relocation / shade
> approach to provide artifacts via a "jakarta" classifier.
> I will open a related PR soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
