[
https://issues.apache.org/jira/browse/DBCP-589?focusedWorklogId=834097&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-834097
]
ASF GitHub Bot logged work on DBCP-589:
---------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/22 09:21
Start Date: 16/Dec/22 09:21
Worklog Time Spent: 10m
Work Description: rmannibucau commented on PR #248:
URL: https://github.com/apache/commons-dbcp/pull/248#issuecomment-1354435743
> impossible to debug, and again, untested
So factually you can debug as any artifact - you shade the sources too, it
is used and got proven working fine by multiple asf projects.
And test is just a matter of writing some test or re-executing the suite
ones if you prefer (but technically/theorically speaking you need just a smoke
test covering the javax integration code to ensure it works since functionally
the rest is already covered).
So overall both points are not blockers and are even almost not true.
> the sanest way to do that is changing the source
So it means jakarta is used on master, by commons rules it becomes dbcp3.
So, as mentionned question is: do we abandon dbcp2 and consider javax is no
more used. If so I join you but if not (and I think we still have 2-3 years of
javax) then we should target to enable jakarta (dbcp2.jakarta package) and
maintain a single code base - would be a pain for no gain at all to fork
ourselves for that.
Issue Time Tracking
-------------------
Worklog Id: (was: 834097)
Time Spent: 1h 20m (was: 1h 10m)
> Provide Jakarta namespace ready artifact of DBCP2
> -------------------------------------------------
>
> Key: DBCP-589
> URL: https://issues.apache.org/jira/browse/DBCP-589
> Project: Commons DBCP
> Issue Type: Bug
> Affects Versions: 2.9.0
> Reporter: Richard Zowalla
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently, we are using a shaded and relocated version of DBCP2 in TomEE to
> have a Jakarta namespace variant of DBCP2.
> For DBCP2 it would require to do some small relocations:
> {code:xml}
> <relocations>
> <relocation>
> <pattern>javax.transaction</pattern>
> <shadedPattern>jakarta.transaction</shadedPattern>
> <excludes>
> <exclude>javax.transaction.xa.**</exclude>
> </excludes>
> </relocation>
> </relocations>
> {code}
> Geronimo and other EE related projects are using the relocation / shade
> approach to provide artifacts via a "jakarta" classifier.
> I will open a related PR soon.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
