aherbert commented on code in PR #406:
URL:
https://github.com/apache/commons-collections/pull/406#discussion_r1278317045
##########
src/main/java/org/apache/commons/collections4/bloomfilter/CountingBloomFilter.java:
##########
@@ -121,7 +186,7 @@ default boolean merge(final Hasher hasher) {
/**
* Merges the specified index producer into this Bloom filter.
*
- * <p>Specifically: all counts for the indexes identified by the {@code
indexProducer} will be incremented by 1.</p>
+ * <p>Specifically: all cells for the indexes identified by the {@code
indexProducer} will be incremented by 1.</p>
Review Comment:
I misread your previous statement "as array always returns the indices in
the number and order they are produced." I took that to mean in order, i.e.
sorted. Re-reading it I see that you are stating that the order matches the
output produced by forEachIndex.
This is fine. But it now means the default implementation of asIndexArray
(which creates sorted, unique indices) is now in conflict with the javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
